Wouter Vanden Hove-2 wrote: > > - I would put Browserviews in a browser-folder. >
Me too, but I have started with this because I had many adapters and browserviews where each one of them are really differents in a business point of view, so I had splited the code, based it more on meaning. So, on one hand, code structure can be based on technologies, on the other hand it can be based on the business. But where I have read do a browser folder I have also read don't do an adapter folder. I think their must be a choice but we can't do both ... or may it be: * link/browser * link/adapter * folder/browser * folder/adpater * topic/browser * topic/adapter * browser/resources * browser/templates ??? Wouter Vanden Hove-2 wrote: > > - Having javascript-files in the main directory seems a bit odd to me. > Normally I would expect those in browser/resources. > > - I don't expect a templates-folder, but rather browser/templates > Yes, I'm agree with you Wouter Vanden Hove-2 wrote: > > - I don't expect a link-folder, but rather an adapters-folder > Same as with browser Wouter Vanden Hove-2 wrote: > > - In docs/HISTORY.txt there is no (unreleased) section for new changes. > Take a look at zest.releaser. It seems you are not using it. > It's extremely handy. > Oups ... I definitly need to use a releaser. Wouter Vanden Hove-2 wrote: > > - Personnally I've stopped using docs/HISTORY.txt and use CHANGES.txt > instead, I see the same evolution in many other packages. > This is done by ZopeSkel ... Wouter Vanden Hove-2 wrote: > > - In setup.py you're not yet using z3c.autoinclude > cfr. http://pypi.python.org/pypi/z3c.autoinclude > This is done by ZopeSkel ... but I had done some tests as an integrator point of views. I'm agree, I will put this back in gallery. Wouter Vanden Hove-2 wrote: > > - In profiles you don't have an uninstall-profile. > I would create one to uninstall at least the css/js-files and the skins. > Yes it is needed but the last time I have tried to do this the uninstall profile was just seen as a default to install things and not use by the quick installer. Do I really need to add also an Extensions/Install.py oldish things ? Wouter Vanden Hove-2 wrote: > > - When using a single skins-layer I would tend use the underscored > > package-name, e.g. collective_gallery > If this is usual ok for this change. Wouter Vanden Hove-2 wrote: > > - You have tests-folder and testing.py. I wouldn't expect both. > I have try to use collective.testcaselayer based on some eggs like Products.ImageEditor. I'm not used to this one, may be I have not used it properly. Wouter Vanden Hove-2 wrote: > > - a locales-folder without an en-subfolder always seems incomplete to me, > even though the po-file doesn't need translation because en is the > default > language. > Oh really ? Thank you very much for this nice feed back WouterVH. _______________________________________________ Product-Developers mailing list [email protected] http://lists.plone.org/mailman/listinfo/product-developers ----- Jean-Michel François aka toutpt http://toutpt.wordpress.com http://twitter.com/toutpt -- View this message in context: http://plone.293351.n2.nabble.com/collective-gallery-1-0b1-ask-for-feed-back-tp5084379p5097471.html Sent from the Product Developers mailing list archive at Nabble.com. _______________________________________________ Product-Developers mailing list [email protected] http://lists.plone.org/mailman/listinfo/product-developers
