But we don't have to block on changelog entries like we do for DCO legal requirements.
For example, in GitLab codebases, we have a CI test that warns if a changelog entry is missing. Unless you tag the review with a label. On Fri, Feb 14, 2020 at 2:22 PM Brian Brazil < [email protected]> wrote: > On Fri, 14 Feb 2020 at 13:15, Matthias Rampke <[email protected]> wrote: > >> The friction is real – DCO is not a submission quality issue but a >> roundtrip one. This would be even more difficult with wording. >> > > I'm with Matthias on this one. We've often have PRs which are ready to > merge, but have been sitting there months waiting for a DCO. > > Brian > > >> >> I agree that in *many* cases contributors can write the changelog >> entry; having the field in the PR template would encourage them to do so >> proactively. >> >> /MR >> >> On Fri, Feb 14, 2020 at 1:12 PM Ben Kochie <[email protected]> wrote: >> >>> DCO is a strawman argument. We're always going to have issues with >>> submission quality. >>> >>> I've had very good luck asking for changelog entries on the >>> node_exporter. >>> >>> On Fri, Feb 14, 2020 at 8:22 AM Brian Brazil < >>> [email protected]> wrote: >>> >>>> On Fri, 14 Feb 2020 at 07:10, Frederic Branczyk <[email protected]> >>>> wrote: >>>> >>>>> I recall Simon having a tool that would largely generate the changelog >>>>> automatically, that worked pretty well last time I was release shepherd. >>>>> Otherwise I'm also happy to discuss a process like in Kubernetes where the >>>>> changelog item is written into the PR. On Thanos we have in the PR >>>>> template >>>>> that people have ensured that the changelog item was added respective to >>>>> the change. Seems like there are options, >>>>> >>>> >>>> >>>> >>>>> I personally would favor something that would be done at contribution >>>>> time, so not all the responsibility falls on the release shepherd as it >>>>> does today, and more generally it seems like the person contributing the >>>>> change probably is also a good candidate to describe it in the changelog. >>>>> >>>> >>>> This is additional friction to contributions, we already have enough >>>> fun getting the DCO signed. It's also an additional burden on every single >>>> PR, we need to individually figure out if it's worth mentioned in the >>>> changelog (many PRs aren't) and then get it in the right category, with >>>> good wording, and handling the regular conflicts as everyone would be >>>> touching the same lines in the same file. >>>> >>>> Even with all that the release shepard would still need to go through >>>> all the commits and double check that nothing was missed, plus fixing poor >>>> wording. I don't think saving 2-3 minutes off a release is worth all these >>>> downsides. >>>> >>>> Brian >>>> >>>> >>>>> >>>>> On Fri, 14 Feb 2020 at 08:05, Callum Styan <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> I'd like to start a discussion around changing how we manage the >>>>>> prometheus/prometheus changelog, specifically the fact that the changelog >>>>>> is generated manually by the release shepherd as part of the release >>>>>> process. >>>>>> >>>>>> We can discuss options for what the new process would look like, such >>>>>> as requiring PR's to include changelog entries before merging or the next >>>>>> release shepherd periodically updating the changelog prior to the >>>>>> release, >>>>>> in more detail later. However I'd first like to get a sense of whether >>>>>> anyone else feels strongly about either changing or not changing this >>>>>> part >>>>>> of the release process. >>>>>> >>>>>> Thanks, >>>>>> Callum. >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Prometheus Developers" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to [email protected]. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/d/msgid/prometheus-developers/CAN2d5OTjOrCfpRF_NXGcQB5nOz%3DVPgnz3LdEk15ucV4PFz%2B4BQ%40mail.gmail.com >>>>>> <https://groups.google.com/d/msgid/prometheus-developers/CAN2d5OTjOrCfpRF_NXGcQB5nOz%3DVPgnz3LdEk15ucV4PFz%2B4BQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Prometheus Developers" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/prometheus-developers/CAOs1UmyOfHbC75bdk55frFQt-KYgD6cg7vh%2BCPSmVmMnSV3sng%40mail.gmail.com >>>>> <https://groups.google.com/d/msgid/prometheus-developers/CAOs1UmyOfHbC75bdk55frFQt-KYgD6cg7vh%2BCPSmVmMnSV3sng%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> >>>> >>>> -- >>>> Brian Brazil >>>> www.robustperception.io >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Prometheus Developers" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLrFL_kN28EiagWYFbKMr5XWC%2Bk7h8n9D8VijvmOnX_5Tw%40mail.gmail.com >>>> <https://groups.google.com/d/msgid/prometheus-developers/CAHJKeLrFL_kN28EiagWYFbKMr5XWC%2Bk7h8n9D8VijvmOnX_5Tw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Prometheus Developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/prometheus-developers/CABbyFmoOTL3BvNguLk%3D%3DpNJi52zP458DugtpOTz0HAdQanyXgQ%40mail.gmail.com >>> <https://groups.google.com/d/msgid/prometheus-developers/CABbyFmoOTL3BvNguLk%3D%3DpNJi52zP458DugtpOTz0HAdQanyXgQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> > > -- > Brian Brazil > www.robustperception.io > -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/CABbyFmqrV9X7pifG_ZR2pt4nMuxALJpB1tRKD-zWH%2B7Zy9sZjQ%40mail.gmail.com.
