On 14 Feb 23:30, 'Matthias Rampke' via Prometheus Developers wrote: > How do I make it so there is no entry?
There is still work to be done after the changelog is generated. > > On Fri, 14 Feb 2020, 18:07 Simon Pasquier, <[email protected]> wrote: > > > Correct, the PR is in the promu repository (I've updated it just now > > to address comments from Brian though it should have been done long > > ago): > > https://github.com/prometheus/promu/pull/170 > > > > Right now, it leverages the PR labels to classify the change (BUGFIX, > > CHANGE, ...) and it uses the PR's title as the changelog entry. It > > wouldn't be hard to mimic what Kubernetes is doing and lookup the > > changelog entry in the PR description as Matthias suggested. If > > nothing is found it can always fallback to the title. > > I agree that asking every PR to include the changelog update might not > > be convenient (both for the contributor and the maintainer). > > > > On Fri, Feb 14, 2020 at 8:10 AM Frederic Branczyk <[email protected]> > > wrote: > > > > > > I recall Simon having a tool that would largely generate the changelog > > automatically, that worked pretty well last time I was release shepherd. > > Otherwise I'm also happy to discuss a process like in Kubernetes where the > > changelog item is written into the PR. On Thanos we have in the PR template > > that people have ensured that the changelog item was added respective to > > the change. Seems like there are options, I personally would favor > > something that would be done at contribution time, so not all the > > responsibility falls on the release shepherd as it does today, and more > > generally it seems like the person contributing the change probably is also > > a good candidate to describe it in the changelog. > > > > > > On Fri, 14 Feb 2020 at 08:05, Callum Styan <[email protected]> > > wrote: > > >> > > >> Hi all, > > >> > > >> I'd like to start a discussion around changing how we manage the > > prometheus/prometheus changelog, specifically the fact that the changelog > > is generated manually by the release shepherd as part of the release > > process. > > >> > > >> We can discuss options for what the new process would look like, such > > as requiring PR's to include changelog entries before merging or the next > > release shepherd periodically updating the changelog prior to the release, > > in more detail later. However I'd first like to get a sense of whether > > anyone else feels strongly about either changing or not changing this part > > of the release process. > > >> > > >> Thanks, > > >> Callum. > > >> > > >> -- > > >> You received this message because you are subscribed to the Google > > Groups "Prometheus Developers" group. > > >> To unsubscribe from this group and stop receiving emails from it, send > > an email to [email protected]. > > >> To view this discussion on the web visit > > https://groups.google.com/d/msgid/prometheus-developers/CAN2d5OTjOrCfpRF_NXGcQB5nOz%3DVPgnz3LdEk15ucV4PFz%2B4BQ%40mail.gmail.com > > . > > > > > > -- > > > You received this message because you are subscribed to the Google > > Groups "Prometheus Developers" group. > > > To unsubscribe from this group and stop receiving emails from it, send > > an email to [email protected]. > > > To view this discussion on the web visit > > https://groups.google.com/d/msgid/prometheus-developers/CAOs1UmyOfHbC75bdk55frFQt-KYgD6cg7vh%2BCPSmVmMnSV3sng%40mail.gmail.com > > . > > > > -- > > You received this message because you are subscribed to the Google Groups > > "Prometheus Developers" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to [email protected]. > > To view this discussion on the web visit > > https://groups.google.com/d/msgid/prometheus-developers/CAM6RFu79WLX7ZZezxMvQdinV5VMdP-0pfPSfTPs45g7RO-qGcA%40mail.gmail.com > > . > > > > -- > You received this message because you are subscribed to the Google Groups > "Prometheus Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/prometheus-developers/CAFU3N5XcbOkOrPVrQ-Mzd-FX%2B7W%2B6kdL_uKOCQ%3DLn1X8f2%2BdtQ%40mail.gmail.com. -- (o- Julien Pivotto //\ Open-Source Consultant V_/_ Inuits - https://www.inuits.eu -- You received this message because you are subscribed to the Google Groups "Prometheus Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/prometheus-developers/20200215122002.GA8431%40oxygen.
signature.asc
Description: PGP signature
