On Tue, 2015-06-09 at 17:38 +0100, Robbie Gemmell wrote:
> I'm not seeing that currently, but I have seen similar sort of things
> a couple of times in the past.
> 
> As you mention, some files get created in the source tree (presumably
> by or due to use of Jython), outwith the normal build areas they 
> would
> be (which would lead to them being cleaned up), and I think that is
> part of the problem sometimes. If the shim, binding or test files get
> updated in certain ways, some bits can become out of sync, leading to
> the type of issue you saw.
> 
> CI doesnt see the issue as it blows away all unversioned files before
> each update. If I see it locally I've just used git-clean to tidy up
> my checkout. I'm not sure what we can do otherwise except put
> something togehter that targets all the extraneous files and removes
> them.

Better to fix dependencies so things get rebuilt properly than to
simply blow them away. Could it be broken swig dependencies leaving out
of date .py files around? I've noticed before that swig does not always
get re-run when it should be.

> Robbie
> 
> On 9 June 2015 at 16:57, Gordon Sim <g...@redhat.com> wrote:
> > I've recently started seeing errors[1] when running tests due to 
> > left over
> > artefacts of previous builds. This happens even for a completely 
> > clean build
> > directory, as some of the offending artefacts seem to be created in 
> > the
> > source tree.
> > 
> > Jython seems to be trying and failing to load cproton. With a 
> > completely
> > clean source and build tree, everything passes, but it is kind of 
> > annoying
> > to have to rely on that. Is anyone else seeing anything similar? 
> > Any ideas
> > as to the cause (I've only seen it happening quite recently) or 
> > possible
> > cures?
> > 
> > 
> > [1]:
> > 
> > > -------------------------------------------------------
> > >  T E S T S
> > > -------------------------------------------------------
> > > Running org.apache.qpid.proton.InteropTest
> > > Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
> > > 0.119 sec
> > > Running org.apache.qpid.proton.JythonTest
> > > 2015-06-09 16:49:29.705 INFO About to call Jython test script:
> > > '/home/gordon/projects/proton-git/tests/python/proton-test' with
> > > '/home/gordon/projects/proton-git/tests/python' added to Jython 
> > > path
> > > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
> > > 5.207 sec
> > > <<< FAILURE!
> > > test(org.apache.qpid.proton.JythonTest)  Time elapsed: 5.203 sec 
> > >  <<<
> > > FAILURE!
> > > java.lang.AssertionError: Caught PyException on invocation number 
> > > 2:
> > > Traceback (most recent call last):
> > >   File "/home/gordon/projects/proton-git/tests/python/proton
> > > -test", line
> > > 616, in <module>
> > >     m = __import__(name, None, None, ["dummy"])
> > >   File
> > > "/home/gordon/projects/proton
> > > -git/tests/python/proton_tests/__init__.py",
> > > line 20, in <module>
> > >     import proton_tests.codec
> > >   File
> > > "/home/gordon/projects/proton
> > > -git/tests/python/proton_tests/codec.py", line
> > > 20, in <module>
> > >     import os, common, sys
> > >   File
> > > "/home/gordon/projects/proton
> > > -git/tests/python/proton_tests/common.py", line
> > > 26, in <module>
> > >     from proton import Connection, Transport, SASL, Endpoint, 
> > > Delivery,
> > > SSL
> > >   File
> > > "/home/gordon/projects/proton-git/tests/../proton
> > > -c/bindings/python/proton/__init__.py",
> > > line 33, in <module>
> > >     from cproton import *
> > >   File
> > > "/home/gordon/projects/proton-git/tests/../proton
> > > -c/bindings/python/cproton.py",
> > > line 29, in <module>
> > >     import _cproton
> > > ImportError: No module named _cproton
> > >  with message: null
> > >         at org.junit.Assert.fail(Assert.java:93)
> > >         at
> > > org.apache.qpid.proton.JythonTest.runTestOnce(JythonTest.java:120
> > > )
> > >         at 
> > > org.apache.qpid.proton.JythonTest.test(JythonTest.java:95)
> > >         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
> > > Method)
> > >         at
> > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorI
> > > mpl.java:57)
> > >         at
> > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodA
> > > ccessorImpl.java:43)
> > >         at java.lang.reflect.Method.invoke(Method.java:606)
> > >         at
> > > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Frame
> > > workMethod.java:45)
> > >         at
> > > org.junit.internal.runners.model.ReflectiveCallable.run(Reflectiv
> > > eCallable.java:15)
> > >         at
> > > org.junit.runners.model.FrameworkMethod.invokeExplosively(Framewo
> > > rkMethod.java:42)
> > >         at
> > > org.junit.internal.runners.statements.InvokeMethod.evaluate(Invok
> > > eMethod.java:20)
> > >         at 
> > > org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
> > >         at
> > > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4Clas
> > > sRunner.java:68)
> > >         at
> > > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4Clas
> > > sRunner.java:47)
> > >         at 
> > > org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
> > >         at 
> > > org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
> > >         at
> > > org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
> > >         at 
> > > org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
> > >         at
> > > org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
> > >         at 
> > > org.junit.runners.ParentRunner.run(ParentRunner.java:300)
> > >         at
> > > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Pro
> > > vider.java:252)
> > >         at
> > > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JU
> > > nit4Provider.java:141)
> > >         at
> > > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Prov
> > > ider.java:112)
> > >         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
> > > Method)
> > >         at
> > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorI
> > > mpl.java:57)
> > >         at
> > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodA
> > > ccessorImpl.java:43)
> > >         at java.lang.reflect.Method.invoke(Method.java:606)
> > >         at
> > > org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithAr
> > > ray(ReflectionUtils.java:189)
> > >         at
> > > org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.in
> > > voke(ProviderFactory.java:165)
> > >         at
> > > org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(P
> > > roviderFactory.java:85)
> > >         at
> > > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(
> > > ForkedBooter.java:115)
> > >         at
> > > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.j
> > > ava:75)
> > > 
> > > 
> > > Results :
> > > 
> > > Failed tests:   test(org.apache.qpid.proton.JythonTest): Caught
> > > PyException on invocation number 2: Traceback (most recent call 
> > > last):(..)
> > > 
> > > Tests run: 9, Failures: 1, Errors: 0, Skipped: 0
> > > 
> > > [INFO]
> > > -----------------------------------------------------------------
> > > -------
> > > [INFO] Reactor Summary:
> > > [INFO]
> > > [INFO] proton-project .................................... 
> > > SUCCESS
> > > [1.207s]
> > > [INFO] proton-j .......................................... 
> > > SUCCESS
> > > [2.310s]
> > > [INFO] proton-jms ........................................ 
> > > SUCCESS
> > > [0.623s]
> > > [INFO] proton-hawtdispatch ............................... 
> > > SUCCESS
> > > [1.558s]
> > > [INFO] proton-tests ...................................... 
> > > FAILURE
> > > [5.737s]
> > > [INFO] proton-j-messenger-example ........................ 
> > > SKIPPED
> > > [INFO]
> > > -----------------------------------------------------------------
> > > -------
> > > [INFO] BUILD FAILURE
> > > [INFO]
> > > -----------------------------------------------------------------
> > > -------
> > > [INFO] Total time: 11.637s
> > > [INFO] Finished at: Tue Jun 09 16:49:34 BST 2015
> > > [INFO] Final Memory: 14M/163M
> > > [INFO]
> > > -----------------------------------------------------------------
> > > -------

Reply via email to