Github user bozzzzo commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/48#discussion_r36180258
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---
@@ -68,12 +69,19 @@ void clear()
}
@Override
- public Type getType()
+ public EventType getEventType()
{
return type;
}
@Override
+ public Type getType() {
+ if (type instanceof Type)
--- End diff --
Why this needs to be so is more obvious if you consider how Core events
(maybe they should be Engine events) would look if reactor had the
ReallyReallyCore events :)
Wdyt, replace Core with Engine in all above comments and leave Core for the
deeper refactoring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
