Hi Juriy, > Btw, as of today, all DOM tests fully pass on IE8. > T.J., do you mind giving it a spin?
On IE7, you mean? (I have only IE6 and IE7 systems right now.) IE7 on Windows still has issues in form, dom, and selector tests with the trunk (assuming "git pull" brings me up to date, I'm a git newbie): ** selector_test.html: >> testSelectorWithEmpty 0 assertions, 2 failures, 0 errors Failure: #level1 *:empty expected: <[<span id="level3_1">, <span id="level3_2">, <div id="level2_3">]>, actual: <[<span id="level3_1">, <span id="level3_2">, <em id="level_only_child">, <div id="level2_3">]> Failure: newlines count as content! expected: <[]>, actual: <[<em id="level_only_child">]> ** dom_test.html: >> testViewportDimensions 1 assertions, 1 failures, 0 errors Failure: NOTE: YOU MUST ALLOW JAVASCRIPT TO RESIZE YOUR WINDOW FOR THIS TEST TO PASS expected: <523>, actual: <485> ** form_test.html: >> testFormMethodsOnExtendedElements 4 assertions, 1 failures, 1 errors Failure: assert got <undefined> TypeError: Object doesn't support this property or method, error= ([object Error]) Can someone point me to an IE7 setting that controls whether JavaScript can change the size of the window? The DOM test may be running afoul of a setting I can't immediately find (in a rush this morning). When I get a chance, I'll fire up an IE6 VM and see how it does. -- T.J. Crowder tj / crowder software / com Independent Software Engineer, consulting services available On Mar 22, 4:06 am, kangax <kan...@gmail.com> wrote: > On Mar 21, 10:16 pm, Completely Free Dating - Andrew > > <andrewjdi...@gmail.com> wrote: > > Hi All, > > > This appears to be a bug in IE, not prototype, as it is not applying > > the class attribute using the specified 'className' property (http:// > > msdn.microsoft.com/en-us/library/ms533560(VS.85).aspx), but using the > > attribute name 'class' instead, so as a work around I have added this > > around line 1809 in prototype.js: > > > if (Prototype.Browser.IE && (parseFloat(navigator.appVersion.split > > ("MSIE")[1]) >= 8.0) && (name == "className")) name='class'; > > Do not ever rely on browser sniffing. The "className" "issue" is fixed > in a trunk with a proper feature test [1]. Ironically, the test still > happens in a huge `Prototype.Browser.IE` branch and only tests for IE > 7,8 differences. We'll take it out of there as soon as possible. > > Btw, as of today, all DOM tests fully pass on IE8. > T.J., do you mind giving it a spin? > > [...] > > [1]http://github.com/sstephenson/prototype/commit/30c1935cdb6f3a8d850dab... > > -- > kangax --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Prototype & script.aculo.us" group. To post to this group, send email to prototype-scriptaculous@googlegroups.com To unsubscribe from this group, send email to prototype-scriptaculous+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/prototype-scriptaculous?hl=en -~----------~----~----~----~------~----~------~--~---