Issue #3013 has been updated by Markus Roberts.

Status changed from Accepted to Needs more information
Assigned to changed from Markus Roberts to Ricky Zhou

Ricky --

I'm trying to validate that this is how we want to handle it (as well as 
looking for any other related problems) and I'm curious about the EINTR rescue:

+                        rescue Errno::EINTR
+                            # Interrupted syscall, try again

Specifically, what circumstances are you envisioning where EINTR would be 
raised by the sysread and we would still want to retry?  I'm not seeing how to 
get there, and my attempts to cause it have failed.


----------------------------------------
Bug #3013: util.rb:execute broken on Ruby <1.8.3
http://projects.reductivelabs.com/issues/3013

Author: Ricky Zhou
Status: Needs more information
Priority: Urgent
Assigned to: Ricky Zhou
Category: exec
Target version: 0.25.3
Affected version: 0.25.2
Keywords: 
Branch: 


Apparently the patch in ticket #2731 introduced one more issue by using 
readpartial, which isn't available until ruby 1.8.3 (RHEL4 at least is 
affected).  I'm not sure how this is normally handled in ruby, but if the 
readpartial function is not available, the code should fall back to sysread 
(along with some code for handling EINTR).

Anybody with better ruby knowledge know how this should be done?


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://reductivelabs.com/redmine/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to