Issue #3013 has been updated by Markus Roberts. Status changed from Accepted to Ready for Testing Branch set to http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/3013
I have a test fix for this up on http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/3013, which incorporates Ricky's change and points that came up in discussion on IRC. I'd like to get it tested as thoroughly as possible so we can get a 0.25.3 out in the next day or two. Things I'd like confirmed: * Execs that capture output (e.g., using yum, rpm, etc.) work under ruby 1.8.1 with this patch. * Ditto on other version of ruby (I'm especially interested in 1.8.2, which is an edge-case for this problem; if you can test under 1.8.2 please report the patch level) * Execs that capture more than 4k worth of output, ditto * Testing this under HPUX to make sure we haven't reverted #2997 * General pounding on it to make sure we haven't just moved the problem If you can test any of these, it would be greatly appreciated; please post your results to the ticket. In the meantime, I'm going to be trying to add so spec-tests to go with the patch, to reduce the chance we ever fall in this particular pit again. ---------------------------------------- Bug #3013: util.rb:execute broken on Ruby <1.8.3 http://projects.reductivelabs.com/issues/3013 Author: Ricky Zhou Status: Ready for Testing Priority: Urgent Assigned to: Markus Roberts Category: exec Target version: 0.25.3 Affected version: 0.25.2 Keywords: Branch: http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/3013 Apparently the patch in ticket #2731 introduced one more issue by using readpartial, which isn't available until ruby 1.8.3 (RHEL4 at least is affected). I'm not sure how this is normally handled in ruby, but if the readpartial function is not available, the code should fall back to sysread (along with some code for handling EINTR). Anybody with better ruby knowledge know how this should be done? -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
