Issue #3013 has been updated by Ricky Zhou.
A few comments on the patch: Why was exit replaced with exit!? Previously, the use of exit! caused a bug where the output from the "puts detail" was lost because stdout was not flushed with exit!. I mentioned a case where this previously showed up in comment 11 on ticket #2731. Also, the second exit after the begin block should probably be exit(1), or maybe even something akin to assert(false) in ruby, since things are definitely not right if execution gets past that block (in fact, is it even possible at all)? One last thing - the += in the /proc/mounts code should probably be changed to <<, since that doesn't create a new string for each iteration of the loop. ---------------------------------------- Bug #3013: util.rb:execute broken on Ruby <1.8.3 http://projects.reductivelabs.com/issues/3013 Author: Ricky Zhou Status: Ready for Testing Priority: Urgent Assigned to: Markus Roberts Category: exec Target version: 0.25.3 Affected version: 0.25.2 Keywords: Branch: http://github.com/MarkusQ/puppet/tree/ticket/0.25.x/3013 Apparently the patch in ticket #2731 introduced one more issue by using readpartial, which isn't available until ruby 1.8.3 (RHEL4 at least is affected). I'm not sure how this is normally handled in ruby, but if the readpartial function is not available, the code should fall back to sysread (along with some code for handling EINTR). Anybody with better ruby knowledge know how this should be done? -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://reductivelabs.com/redmine/my/account--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to [email protected].
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
