On May 25, 2008, at 2:04 AM, James Turnbull wrote: > > David Lutterkort wrote: >> >> On Fri, 2008-05-23 at 08:42 -0400, The Anarcat wrote: >>> In the case, the same process could be follow: hooks in topical >>> repositories would send mail to -commit@ on push. >> >> I don't believe that that will achieve much .. it won't increase >> discussions around the code. People will just look at that list as a >> FYI, and then go on there merry way. I'd wager money that there >> won't be >> more than two non-commit mails per month on that list. Of course, >> there's nothing wrong with a commit list. >> >> Sending patches to the dev list and requiring ACK's on the list >> _before_ >> commit gives you much more active participation. Part of what I was >> suggesting was to have livelier discussions around the actual code, >> which isn't happening right now. > > What David said - I'd be happy to see it go to both. Though on the > ACK's I am going to assume that if people don't ACK within x timeframe > that indicates they accept the patch.
There's also a difference between commits to personal repositories and commits to the master repos. I like having commit notices for all repositories, but I agree with David that they won't automatically result in conversation about the patches. At this point, I'd prefer to stick with everyone setting up commits for their personal repositories, but then when a commit is being considered for merging, it should be sent to -dev. I'm still a bit unclear on what the actual development process will look like, WRT people sending patches to -dev, but I guess we'll just have to sort it out as we go. -- The big thieves hang the little ones. -- Czech Proverb --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en -~----------~----~----~----~------~----~------~--~---
