On May 23, 2008, at 7:42 AM, The Anarcat wrote:
> On Thu, May 22, 2008 at 06:38:12PM -0700, Brian Finney wrote:
>>
>> As a non active (hopefully active in the future)
>> contributer/developer, I would find emailed patches very useful for
>> visibility into the code base and where things are going, and as a
>> nice carrot hanging out in front of me to hopefully motivate me to
>> contribute. Of course the usability of actual contributers is more
>> important. Perhaps a merge mailing list that automatically gets
>> emailed patches when merges happen on major branches if this doesn't
>> go through? (github probably has something I could subscribe to
>> though, I'll have to look into it)
>
> For me that's the best solution: having a -commits mailing list that
> gets all the commits done on the master branches will ensure maximum
> peer review of the actual master code, the one that matters.
>
> Branch maintainers still have the duty to actually review the topical
> branches before they merge so I'm not sure it's relevant to share
> those
> "proposed patches" with everyone, unless we want to distribute the
> task
> of reviewing proposed patches to the master branches.
>
> In the case, the same process could be follow: hooks in topical
> repositories would send mail to -commit@ on push.
>
> In general, it would be important to have tags in the commitmail
> saying
> what the patch applies to: a topical branch (and which(, a "stable"
> master branch,
> the "next release" master branch, etc.
That's a good point -- another option is to just extend the -commits
list so that everyone posts their commits to it, rather than just the
commits sent to the master repo.
Anyone want to set up a commit hook for github that would make this
easy?
--
To my embarrassment I was born in bed with a lady.
--Wilson Mizner
---------------------------------------------------------------------
Luke Kanies | http://reductivelabs.com | http://madstop.com
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Puppet Developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/puppet-dev?hl=en
-~----------~----~----~----~------~----~------~--~---
