Luke Kanies wrote: > On May 23, 2008, at 7:42 AM, The Anarcat wrote: > >> Branch maintainers still have the duty to actually review the topical >> branches before they merge so I'm not sure it's relevant to share >> those >> "proposed patches" with everyone, unless we want to distribute the >> task >> of reviewing proposed patches to the master branches.
I think we want broad ranging feedback - especially given the multi-platform nature of Puppet. Obviously not every patch is going get comment and ultimate accountability for this rests with Luke and/or me but I think it's a good model. It at least makes the development process somewhat more transparent and hopefully encourages discussion and debate. >> In the case, the same process could be follow: hooks in topical >> repositories would send mail to -commit@ on push. >> >> In general, it would be important to have tags in the commitmail >> saying >> what the patch applies to: a topical branch (and which(, a "stable" >> master branch, >> the "next release" master branch, etc. +1 > That's a good point -- another option is to just extend the -commits > list so that everyone posts their commits to it, rather than just the > commits sent to the master repo. > > Anyone want to set up a commit hook for github that would make this > easy? This would be my preferred approach. Again - I will document this workflow with some pretty pictures sometime today and post a link here. Regards James Turnbull -- James Turnbull ([EMAIL PROTECTED]) Author of: * Pulling Strings with Puppet (http://www.amazon.com/gp/product/1590599780/) * Pro Nagios 2.0 (http://www.amazon.com/gp/product/1590596099/) * Hardening Linux (http://www.amazon.com/gp/product/1590594444/)
signature.asc
Description: OpenPGP digital signature
