----- "Markus Roberts" <[email protected]> wrote: > So do we have any characterization of who didn't want to see code on > puppet-dev? Are there any individuals that would like to come forward > and speak for that side, or does anyone know who (in a general, > demographic sense) was pushing for this change?
I mentioned, I think recently to James as well, that email based code review is pretty horrible and I wish something better existed, not sure if I am who was referred to but there it is. Little things like no code highlighting makes it hard to read, big things like not seeing the whole context especially in complex code with many levels of inheritance means it's only useful to people who are very familiar with the code. This is a general problem with OO code and diffs though so not project specific. Opposite side of the coin I *like* that it's email because it gets pushed to me, I'd never regularly visit some web based reviewer and read comments there. Having said that though as a non core dev the code as such is of little use to me, what I do find very useful is the discussions about why thigns were done, reading the code comments (when people bother :P) and I also tend to pick up lots of nice ruby bits along the way and get to know some of how you work. So the code review has enough value for me even without understanding the code base, much of how I approach Puppet use is by observing behavior and knowing just enough (hopefully) about internals to be able to at least understand those behaviors. Staying on top of commits and tickets help me keep pace at that level without needing the whole deep understanding of the code paths. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
