On Oct 28, 2010, at 10:12 AM, Markus Roberts wrote: > > We just absolutely should not have two patch review lists, one for > community patches and one for puppet labs employee patches. > > Strongly agreed.
I don't think anyone was recommending that - the question was what's the best way to review patches, not how we can do privately. If we have two lists, they'll both be public, and if we have a list and a review tool, they'll both be public. -- The most overlooked advantage to owning a computer is that if they foul up there's no law against wacking them around a little. -- Joe Martin --------------------------------------------------------------------- Luke Kanies -|- http://puppetlabs.com -|- +1(615)594-8199 -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
