On Thu, Oct 28, 2010 at 1:13 PM, Luke Kanies <[email protected]> wrote: > On Oct 28, 2010, at 10:12 AM, Markus Roberts wrote: > >> We just absolutely should not have two patch review lists, one for >> community patches and one for puppet labs employee patches. > > Strongly agreed. > > I don't think anyone was recommending that - the question was what's the > best way to review patches, not how we can do privately. If we have two > lists, they'll both be public, and if we have a list and a review tool, > they'll both be public.
Right, I don't mean to keep bumping this thread, but original email stated: "Because of this we're going to try no longer sending patches from the internal dev team to the list (community members will still need to send patches to the list for review). We're working through the best way to do code review internally, so some of that process of nitpicking over individual lines of code may be less visible from the outside until we determine a useful way to make that visible." The "no longer sending patches from the internal dev team to the list" and "may be less visible from the outside" statements are what I interpreted as private patch reviews, and I advise against. If my interpretation isn't correct, then that's great, and I have a less strong objection to the proposal. Just trying to make sure we're all on the same page. -- Jeff McCune http://www.puppetlabs.com/ -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
