> > >> Right now, I wanted to ask a couple of questions about the following > >> next patch: > >> > https://github.com/puppetlabs/puppet/commit/cfe202539018b27c35ff833152f237bc30569a5f > > > > Like why all the tests were deleted? > > OK, I've been getting some flak about this one. Clearly we (Paul Berry and I) should have done this in a separate commit with its own explanation. When we changed the way the REST interface connects to the Indirector, these tests started failing. When we started investigating what these tests were actually doing, we found that despite being labeled "integration" tests, they were actually only successfully testing a tiny sliver of the system - so much of the machinery was stubbed out with mock objects that the only part of puppet remaining to get tested was: > When object.save() gets called, the Indirector makes an HTTP request.
and I'm certain that this behavior is sufficiently tested in spec/unit/network/http/* and the acceptance test suite. And since these tests were launching Webrick, they were some of the slowest tests in the suite, and have a tendency to fail sporadically on our Hudson CI server. The cost of fixing the tests, at this point, seemed much higher than their value. -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
