On 29/10/10 23:01, Jacob Helwig wrote: > On Fri, 29 Oct 2010 20:40:48 +0200, Brice Figureau wrote: >> >> I suppose once the iteration is done and patches merged in next, raising >> a red flag on some changes will be too late, is that right (at least for >> this iteration)? >> > > The patches are being merged into next before the end of the iterations, > so I think that commenting on them once they hit next is perfectly > reasonable (and would be rather welcome, in my opinion), especially if > you notice anything -1 worthy.
So basically, until we get something to review PL patches we're out of luck commenting on them, or should we use github patch comment? Right now, I wanted to ask a couple of questions about the following next patch: https://github.com/puppetlabs/puppet/commit/cfe202539018b27c35ff833152f237bc30569a5f What's the proper way to do that? Open a thread here, ask on github, irc? -- Brice Figureau My Blog: http://www.masterzen.fr/ -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-dev?hl=en.
