commented a few things in the PR. Before you start the uploading uniforms part of the code you might want to read on "uniforms blocks" and "buffers block". Its a technique that uses opengl buffers to read and write uniforms values. The main reason I didn't use it in my library is because its a opengl 3.1 feature and I didn't have a nice buffer api to use. If you were to use this feature you could probably cut through the "guess my upload function bullsh*t" (sorry). If you have the lastest version of the opengl programming guide, there's a section that explain it very well (chapter 2.2: Interface block).
Le lundi 11 juillet 2016 07:36:29 UTC-4, Benjamin Moran a écrit : > > Thanks, I appreciate that. > > One of the reasons that I opened the pull request was to see if anyone > would point out any glaring flaws, before I put more work into it. I trust > your opinion on this, since your clearly knowledgeable about it. > -- You received this message because you are subscribed to the Google Groups "pyglet-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/pyglet-users. For more options, visit https://groups.google.com/d/optout.
