First of all sorry for the slow reply. "Real life" stuff came up, and you know how that goes I'm sure!
Thank you very much for taking the time to give all of your feedback. You've given me more than enough to work with for the time being. I haven't really looked into uniform/buffer blocks, but I will certainly do so. I wasn't quite sure where to draw the line with supported OpenGL versions. I think all (most) of the functions I'm using now work back to 2.1. Realistically though, I don't think there is very much demand for pre-130 GLSL support, so maybe OpenGL 3.1/GLSL #140 would be a nice minimum support level. I think my pull request has accomplished it's purpose for now (getting some feedback), so I think I'll go ahead and close it until I put some more work into this. I'm still not sure if the core devs are even interested in merging something like this, so maybe I should get some confirmation on that first. If not, I think your library might already cover things. On Tuesday, July 12, 2016 at 10:36:46 AM UTC+9, [email protected] wrote: > > commented a few things in the PR. Before you start the uploading uniforms > part of the code you might want to read on "uniforms blocks" and "buffers > block". Its a technique that uses opengl buffers to read and write uniforms > values. The main reason I didn't use it in my library is because its a > opengl 3.1 feature and I didn't have a nice buffer api to use. If you were > to use this feature you could probably cut through the "guess my upload > function bullsh*t" (sorry). If you have the lastest version of the opengl > programming guide, there's a section that explain it very well (chapter > 2.2: Interface block). > > Le lundi 11 juillet 2016 07:36:29 UTC-4, Benjamin Moran a écrit : >> >> Thanks, I appreciate that. >> >> One of the reasons that I opened the pull request was to see if anyone >> would point out any glaring flaws, before I put more work into it. I trust >> your opinion on this, since your clearly knowledgeable about it. >> > -- You received this message because you are subscribed to the Google Groups "pyglet-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/pyglet-users. For more options, visit https://groups.google.com/d/optout.
