Hi,

Am 26.07.2011 12:30, schrieb Martin Zibricky:
Giovanni Bajo píše v Út 26. 07. 2011 v 12:04 +0200:

I oppose any drop in compatibility that it is not backed by a strong
showstopper. If it's needed for Python3, we can still make it
conditional
so that it only gets triggered for newer Python versions.

Use subprocess module will give us more portability and better unicode
handling, especially for Windows platform.

Not opposed to subprocess, but I'll mention using it (if we are talking the "stock" Python bundled version) will probably only improve Unicode handling in the future when pyinstaller moves to Python 3.x. In Python 2.x versions, there sadly is no Unicode support with subprocess, meaning - seemingly regardless of platform (I can talk for Windows, Linux and OS X from my own experience) - that Unicode arguments containing non-ascii characters passed to subprocess.Popen et al need to be encoded (e.g. with sys.getfilesystemencoding()), otherwise you get UnicodeEncodeErrors, and arguments read back from pipes are byte strings. I don't know though if the subprocess32 module that Giovanni mentioned has proper Unicode support.

Because it allows running subprocesses without executing windows shell.
Windows shell has never been ported to handle unicode properly.
Bypassing windows shell we do not need to worry about different windows
code pages and stuff like that.

Windows and unicode is showstopper.

--
Florian Höch

--
You received this message because you are subscribed to the Google Groups 
"PyInstaller" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/pyinstaller?hl=en.

Reply via email to