On Wed, 2011-07-27 at 14:46 +0200, Florian Höch wrote: > Hi, > > Am 26.07.2011 12:30, schrieb Martin Zibricky: > > Giovanni Bajo píše v Út 26. 07. 2011 v 12:04 +0200: > >> > >> I oppose any drop in compatibility that it is not backed by a strong > >> showstopper. If it's needed for Python3, we can still make it > >> conditional > >> so that it only gets triggered for newer Python versions. > > > > Use subprocess module will give us more portability and better unicode > > handling, especially for Windows platform. > > Not opposed to subprocess, but I'll mention using it (if we are talking > the "stock" Python bundled version) will probably only improve Unicode > handling in the future when pyinstaller moves to Python 3.x. In Python > 2.x versions, there sadly is no Unicode support with subprocess, meaning > - seemingly regardless of platform (I can talk for Windows, Linux and OS > X from my own experience) - that Unicode arguments containing non-ascii > characters passed to subprocess.Popen et al need to be encoded (e.g. > with sys.getfilesystemencoding()), otherwise you get > UnicodeEncodeErrors, and arguments read back from pipes are byte strings. > I don't know though if the subprocess32 module that Giovanni mentioned > has proper Unicode support.
I don't know either, but I can't think of a case where we need to pass Unicode arguments to a process spawned by PyInstaller. Am I missing something? (Curiously, we used to have a similar bug within the bootloader: when the first process invoked the second one, we used to have a bug in propagating Unicode arguments under Windows. It was fixed some years ago) -- Giovanni Bajo :: [email protected] Develer S.r.l. :: http://www.develer.com My Blog: http://giovanni.bajo.it -- You received this message because you are subscribed to the Google Groups "PyInstaller" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/pyinstaller?hl=en.
