On 1/29/22 3:14 AM, Lrupert via Python-Dev wrote:
> As someone who is watching the python/cpython repository, I'm very used to
see lots of traffic. But
> lately there have been a surge of spammy PRs which are about the same,
generally very trivial subject
> but individually fixing each occurrence one by one:
> - Add coverage to X (tens of them, as separate PRs)
> - Make `test_xxx` executable with direct invocation (tens of them, as
separate PRs)
> - Lint source with flake8, fix linting errors (stylistic changes)
I am aware of the coverage PRs, and I think they are quite useful -- a couple bugs were fixed in one of my modules
thanks to that author's efforts to make sure all branches were tested.
Likewise, the executable test PRs are useful -- I haven't followed them closely, but at the beginning a few of us asked
the author to submit one PR for a handful of related fixes, which makes it easier for reviewers to assess the changes.
So those two types are not spam.
I am unaware of the stylistic changes -- could you list a few?
> And lots of non-committer PR reviews that only approve.
I have seen this. Quite irritating.
> In the past there were one or two people who would submit typo fixes, but
most of them weren't making it continuously.
> The situation right now feels much worse than those.
As I said earlier, the coverage and executable tests are legitimate, and I welcome them -- they are helping increase the
quality of Python's code.
--
~Ethan~
_______________________________________________
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-le...@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at
https://mail.python.org/archives/list/python-dev@python.org/message/TCRMIQ6ZVVDOO3MIVHT5WWUWDEY3A3J3/
Code of Conduct: http://python.org/psf/codeofconduct/
