On Sat, Jan 29, 2022 at 7:38 PM Inada Naoki <songofaca...@gmail.com> wrote:
> On Sun, Jan 30, 2022 at 12:03 PM Ethan Smith <et...@ethanhs.me> wrote: > > > > As a non-committer, I want to make a plea for non-committer approval > reviews, or at least that they have a place. When asked how outsiders can > contribute I frequently see "review open PRs" as a suggested way of > contributing to CPython. Not being able to approve PRs that are good would > be a barrier to those contributions. > > > > Furthermore, I am collaborating with a couple of core devs, it would > make collaboration more difficult if I couldn't review their work and say > that I thought the changes looked good. > > > > You can still write a review comment, including "LGTM". Fair enough, I suppose commenting with "LGTM" works just as well. > What you can > not is labeling PR as "Approved." > So I don't think it makes collaboration difficult. > By preventing approval from others, we can easily find PRs approved > from core-devs or triage members but not merged yet. > > > I know "drive by approvals" are annoying but I think it is unfortunately > part of open source projects. > > > > Sorry, but I don't think so. > Well, if you disallow drive-by approvals, you will still get drive-by LGTM comments. People seem to believe that adding their approval will expedite a PR merge, for some reason (or want to bump a stale PR in hopes of a quicker merge). > > -- > Inada Naoki <songofaca...@gmail.com> >
_______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-le...@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/QJ5QBB4XCFU3DFSOFBRUJB5XC4UMX7TK/ Code of Conduct: http://python.org/psf/codeofconduct/
