On Dec 20, 2012, at 11:18 AM, Ben Finney wrote: >Terry Reedy <tjre...@udel.edu> writes: > >> On 12/12/2012 10:56 AM, Lennart Regebro wrote: >> >> >> It seems like calling get_timezone() with an unknown timezone >> >> should just throw ValueError, not necessarily some custom >> >> Exception? >> > >> > That could very well be. What are others opinions on this? >> >> ValueError. That is what it is. Nothing special here. > >I think it's useful to have this raise a custom exception >UnknownTimeZoneError, subclassed from ValueError. That satisfies those >(including me!) who think it should be a ValueError, while also making >the exception more specific so it can be handled apart from other >possible ValueError causes. > >In short: +1 to ‘class UnknownTimeZoneError(ValueError)’.
That would be `class UnknownTimeZoneError(ValueError, TimeZoneError)`. -Barry
signature.asc
Description: PGP signature
_______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
