| jayvdb closed this task as "Resolved". jayvdb edited the task description. (Show Details) |
EDIT DETAILS
Evaluation:Due to difficulties early on regarding design, we agreed to focus on getting solid prototypes for the MVP, removing the expected nice integration of the Thanks functionality into the Revision and Page classes.
I am generally quite pleased with the improvements over the last three weeks, as the code in gerrit patches is working, quality is going up, and your [[last blog post|http://bhyrava.me/code/gsoc/wikimedia/2016/06/23/GSoC7/]] ( especially the part about reading code), indicates that you're on the right path to understanding Pywikibot, open source and most importantly yourself.
However the deadline is fast approaching, and the reduced MVP hasnt arrived. The patches are in good shape, but have quite a bit more work required to be polished enough to be merged. Some simple things like setting `write = True` havent been done, despite being explained in `tests/README.rst`. That alone is an automatic "must not be merged" problem. It shouldnt need to be a review comment, and shouldnt need to be repeated. There are plenty of examples, including in `flow_tests` which was your guide.
Given more time, I am confident that you could complete the MVP, and probably even complete the project. But the deadline has arrived.
I strongly recommend that you stay involved in open source to augment your formal education, practise getting code merged, and participate in Google Summer of Code again next year, as I am sure you will be better prepared for it.
Evaluation: Fail
...
Additional comments:Evaluation:Due to difficulties early on regarding design, we agreed to focus on getting solid prototypes for the MVP, removing the expected nice integration of the Thanks functionality into the Revision and Page classes.
I am generally quite pleased with the improvements over the last three weeks, as the code in gerrit patches is working, quality is going up, and your [[last blog post|http://bhyrava.me/code/gsoc/wikimedia/2016/06/23/GSoC7/]] ( especially the part about reading code), indicates that you're on the right path to understanding Pywikibot, open source and most importantly yourself.
However the deadline is fast approaching, and the reduced MVP hasnt arrived. The patches are in good shape, but have quite a bit more work required to be polished enough to be merged. Some simple things like setting `write = True` havent been done, despite being explained in `tests/README.rst`. That alone is an automatic "must not be merged" problem. It shouldnt need to be a review comment, and shouldnt need to be repeated. There are plenty of examples, including in `flow_tests` which was your guide.
Given more time, I am confident that you could complete the MVP, and probably even complete the project. But the deadline has arrived.
I strongly recommend that you stay involved in open source to augment your formal education, practise getting code merged, and participate in Google Summer of Code again next year, as I am sure you will be better prepared for it.
Evaluation: Fail
TASK DETAIL
EMAIL PREFERENCES
To: jayvdb
Cc: jayvdb, EBernhardson, Legoktm, darthbhyrava, Xqt, Mpaa, valhallasw, kaldari, polybuildr, pywikibot-bugs-list, Aklapper, Billghost, zhuyifei1999, Sumit, Zppix, 01tonythomas, Lethexie, Mdupont, fbstj, Catrope, Jay8g
Cc: jayvdb, EBernhardson, Legoktm, darthbhyrava, Xqt, Mpaa, valhallasw, kaldari, polybuildr, pywikibot-bugs-list, Aklapper, Billghost, zhuyifei1999, Sumit, Zppix, 01tonythomas, Lethexie, Mdupont, fbstj, Catrope, Jay8g
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
