On Tue, Oct 11, 2016 at 1:07 PM, Ashijeet Acharya
> This series adds blockdev-add support for SSH block driver.
> Patch 1 prepares the code for the addition of a new option prefix,
> which is "server.". This is accomplished by adding a
> ssh_has_filename_options_conflict() function which helps to iterate
> over the various options and check for conflict.
> Patch 2 first adds InetSocketAddress compatibility to SSH block driver
> and then makes it accept a InetSocketAddress under the "server" option.
> The old options "host" and "port" are supported as legacy options and
> then translated to the respective InetSocketAddress representation.
> Patch 3 drops the usage of "host" and "port" outside of
> ssh_has_filename_options_conflict() and
> ssh_process_legacy_socket_options() functions in order to make them
> legacy options completely.
> Patch 4 helps to allow blockdev-add support for the SSH block driver
> by making the SSH option available.
> *** This series depends on the following patch: ***
> "qdict: implement a qdict_crumple method for un-flattening a dict"
> from Daniel's "QAPI/QOM work for non-scalar object properties"
> Ashijeet Acharya (4):
> block/ssh: Add ssh_has_filename_options_conflict()
> block/ssh: Add InetSocketAddress and accept it
> block/ssh: Use InetSocketAddress options
> qapi: allow blockdev-add for ssh
> block/ssh.c | 121
> qapi/block-core.json | 24 +++++++++-
> 2 files changed, 125 insertions(+), 20 deletions(-)
I received a mail saying my series failed the automatic build test but
it builds completely fine (after applying Dan's patch obviously) in my
Going through the config output of the test script, I see that the
supporting library for SSH which is "libssh2" seems to be disabled and
maybe causes the build to fail. I am able to reproduce it locally with
Any other thoughts?