Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > This series adds blockdev-add support for SSH block driver. > > Patch 1 prepares the code for the addition of a new option prefix, > which is "server.". This is accomplished by adding a > ssh_has_filename_options_conflict() function which helps to iterate > over the various options and check for conflict. > > Patch 2 first adds InetSocketAddress compatibility to SSH block driver > and then makes it accept a InetSocketAddress under the "server" option. > The old options "host" and "port" are supported as legacy options and > then translated to the respective InetSocketAddress representation. > > Patch 3 drops the usage of "host" and "port" outside of > ssh_has_filename_options_conflict() and > ssh_process_legacy_socket_options() functions in order to make them > legacy options completely. > > Patch 4 helps to allow blockdev-add support for the SSH block driver > by making the SSH option available.
Commented on patch 2, the rest looks good to me at first sight. Just curious, what kind of testing did you give the series? Kevin