Thanks for the list. I assume that you have run some checker... which one? On Tue, Sep 1, 2009 at 12:25 AM, philippe van dyck<[email protected]> wrote: > > -Should org.qi4j.runtime.composite.BridgeClassLoader.loadClass be > synchronized (superclass is).
I am not totally sure that it is necessary, since there is no members being read/written. The only thing I can think of is an additional resolve() call being averted, but I think all this code is only called during start-up, likely in a single thread. > -Should org.qi4j.spi.util.json.JSONObject.Null implement hashCode() (it > overrides equals). Null is an inner static private class, and the owning class ensures that there is only one instance. hashCode() will always be the same. equals() is overridden to allow Null == null semantics (questionable perhaps). > -org.qi4j.runtime.value.ValuePropertyModel field propertyInfo hides a field > with the same name declared in the class PersistentPropertyModel. propertyInfo is indeed unnecessary. There is also a PropertyType field with the same issue in the same classes. But the initialization is different, so I would like to have Rickard's opinion on this. Either the superclass's field is pushed down to its subclasses, or it being passed in constructor. > -org.qi4j.api.unitofwork.UnitOfWorkConcern.invoke REQUIRED case continues in > MANDATORY case continues in REQUIRES_NEW (breaks needed, very probably) Yes. I have rewritten the troubled code, will commit shortly. > sharing almost the same code : > org.qi4j.api.constraint.ConstraintViolationException > and org.qi4j.api.composite.ParameterConstraintViolationException Good one. I have killed off the PCVE completely. > org.qi4j.runtime.service.ServiceModel.calculateConfigurationType() > and org.qi4j.runtime.getConfigurationType() Good. I have changed so that the Qi4jRuntime delegates to the ServiceModel method. Cheers -- Niclas Hedhman, Software Developer http://www.qi4j.org - New Energy for Java I live here; http://tinyurl.com/2qq9er I work here; http://tinyurl.com/2ymelc I relax here; http://tinyurl.com/2cgsug _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
