On Tue, Sep 1, 2009 at 11:55 AM, Rickard Öberg<[email protected]> wrote: > Niclas Hedhman wrote: >>> >>> -org.qi4j.runtime.value.ValuePropertyModel field propertyInfo hides a >>> field >>> with the same name declared in the class PersistentPropertyModel. >> >> propertyInfo is indeed unnecessary. There is also a PropertyType field >> with the same issue in the same classes. But the initialization is >> different, so I would like to have Rickard's opinion on this. Either >> the superclass's field is pushed down to its subclasses, or it being >> passed in constructor. > > Yeah, the reason is the different initialization. Removing the duplicate and > fixing it through constructor argument passing would be ok though.
Ok, I'll do that... Cheers -- Niclas Hedhman, Software Developer http://www.qi4j.org - New Energy for Java I live here; http://tinyurl.com/2qq9er I work here; http://tinyurl.com/2ymelc I relax here; http://tinyurl.com/2cgsug _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
