Le 1 sept. 2009 à 05:51, Niclas Hedhman a écrit :
Thanks for the list. I assume that you have run some checker...
which one?
http://www.instantiations.com/codepro/analytix/about.html
A lot of dodgy rules and false positives. Dependency check really well
done.
On Tue, Sep 1, 2009 at 12:25 AM, philippe van dyck<[email protected]>
wrote:
-Should org.qi4j.runtime.composite.BridgeClassLoader.loadClass be
synchronized (superclass is).
I am not totally sure that it is necessary, since there is no members
being read/written. The only thing I can think of is an additional
resolve() call being averted, but I think all this code is only called
during start-up, likely in a single thread.
Looking at the code, I was not sure either, that is when I had the
costly 'synchronized'.
(BTW, this is not a very good idea to synchronize on the method, we'll
see that after V1, maybe)
-Should org.qi4j.spi.util.json.JSONObject.Null implement hashCode()
(it
overrides equals).
Null is an inner static private class, and the owning class ensures
that there is only one instance. hashCode() will always be the same.
equals() is overridden to allow Null == null semantics (questionable
perhaps).
I did'nt take a deep look into it but the analyzer gets berserk on
this one... (JIRA for >V1?)
_______________________________________________
qi4j-dev mailing list
[email protected]
http://lists.ops4j.org/mailman/listinfo/qi4j-dev
