Re: Possible problem with qmail-qmtpc patch

[Ian Lance Taylor]

Ian Lance Taylor <[EMAIL PROTECTED]> writes:

> > I think there may be a problem with the patches to qmail-remote that make
> > it speak QMTP based on MXPS.
> > 
> > If the QMTP connection fails (because the remote host doesn't have a qmtpd
> > running) this failure will be logged as
> > 
> > deferral: Connected_to_194.47.249.19_but_connection_died._(#4.4.2)/
> > 
> > which means that the message will not be retried at the next best MX but
> > go back to the queue.
> 
> I don't see it.

Now I see it.  You can't call connect twice on the same socket.  This
patch, on top of Russ's patch, fixes it.

Ian

--- qmail-remote.c.~1~  Sat Jan  6 22:49:02 2001
+++ qmail-remote.c      Tue Jan 16 10:30:29 2001
@@ -531,6 +531,9 @@
        partner = ip.ix[i].ip;
        qmtp(); /* does not return */
       }
+      close(smtpfd);
+      smtpfd = socket(AF_INET,SOCK_STREAM,0);
+      if (smtpfd == -1) temp_oserr();
     }
     if (timeoutconn(smtpfd,&ip.ix[i].ip,(unsigned int) smtp_port,timeoutconnect) == 
0) {
       tcpto_err(&ip.ix[i].ip,0);