Hi Thomas,
I've noticed another small issue:
When a table object is created and disposed again, the event-listener to
"changeLocale" is still attached, which will lead to an error when the locale
is changed after table object disposal.
The attached patch worked for our application, but is not tested any further.
Feel free to take a look at it (it's not _that_ complicated ;) ) and commit to
the qooxdoo_legacy_0_7_x branch.
Greetings,
Kuddel
> [...]
> Ah, you guys got us with our pants down :). Yes, these are actually
> leaks in the framework. I've fixed those from the log output in
> legacy_0_7_x (but maybe there are more). If you check your applications
> and come across further 'Missing' entries that pertain to framework
> classes, do file them (either through mailing list or bugzilla), this is
> always helpful for us. Of course, patches are welcome.
>
> I have also expanded the destructor wiki page a little.
>
> Cheers,
> Thomas
>
> [...]
Index: Table.js
===================================================================
--- Table.js (revision 13985)
+++ Table.js (working copy)
@@ -1941,6 +1941,11 @@
destruct : function()
{
+ // remove the event listener which handled the locale change
+ qx.locale.Manager.getInstance().removeEventListener("changeLocale",
+ this._onChangeLocale,
+ this);
+
// we allocated these objects on init so we have to clean them up.
var selectionModel = this.getSelectionModel();
if (selectionModel)
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
