Romain FLIEDEL wrote:
> I've seen that you add missing destructs in rev 14009
> I found an issue with qx.ui.table.pane.CellEvent
>
> I think you should use disposeFields instead of disposeObjects because
> right now if a CellEvent is triggered then the table seems not to react
> on click anymore (no focus change for instance)
> With the patch bellow it seems to be working (and the disposer doesn't
> complain)
>
> Index: CellEvent.js
> ===================================================================
> --- CellEvent.js (revision 14042)
> +++ CellEvent.js (working copy)
> @@ -116,6 +116,6 @@
>
> destruct : function()
> {
> - this._disposeObjects("_scroller");
> + this._disposeFields("_scroller");
> }
> });
>
> You should probably check that such problem have not been introduced in
> the other corrections you made
> (I'm sorry I don't have enough time to help you correcting those bugs)
>
>
Well, reporting the issues is in itself a big help, so don't worry too
much. I've changed the code. The problem is really that the disposer can
only hint at issues, but you cannot just mechanically poor all the
'missing' messages into the 'destruct' section (otherwise we would
probably do it automatically in the framework :). Data items can be
shared between object instances and only if you know the whole widget
code can you decide whether a data item should be released with the
destruction of this particlular instance, or if it is still used by some
other instance - the disposer complaining or not. - I'm not sure about
all possible side effects myself so this process is a bit of a trial and
error, and depends on you guys to give feedback if things go astray :).
In this particular case it's really a hack to use _disposeFields to
silence the disposer, since according to the doc _scroller is a proper
qooxdoo object instance which you should use _disposeObject for. But
there you go...
Thomas
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
