Hi again Thomas,
> [...]
> if it looks like I've de-stabilized the code with all the 'destruct'
> entries too much, I'm going to revert all my changes and file bug
> reports for each, so people can sort them out with more time and
> subtlety. We'll see...
> [...]
I don't think that you've de-stabilized it too much!
Let's face it: There are not that many people around willing do that job :-/
...me neither
So keep up the good work!
Best
Kuddel
>
> Thomas
>
>
>> Hi Thomas,
>>
>> according to your request in the log of R14009 (legacy 0.7.x),
>> "...please check for unintended side effects."
>> I can offer a patch to another (new) destructor issue:
>>
>> The _tableContainer object in qx.ui.table.pane.Pane is created with
>> document.createElement("div");
>> and is therefore no qooxdoo-object to be destroyed by _disposeObjects().
>> I'm not sure if the object should be disposed at all (by _disposeFields())
>> ...
>> does anyone have information on that?
>>
>> If it should be destroyed, see (the very obvious ;) ) patch for details
>>
>> /Kuddel
>>
>>
>>
>>> [...]
>>> Well, reporting the issues is in itself a big help, so don't worry too
>>> much. I've changed the code. The problem is really that the disposer can
>>> only hint at issues, but you cannot just mechanically poor all the
>>> 'missing' messages into the 'destruct' section (otherwise we would
>>> probably do it automatically in the framework :). Data items can be
>>> shared between object instances and only if you know the whole widget
>>> code can you decide whether a data item should be released with the
>>> destruction of this particlular instance, or if it is still used by some
>>> other instance - the disposer complaining or not. - I'm not sure about
>>> all possible side effects myself so this process is a bit of a trial and
>>> error, and depends on you guys to give feedback if things go astray :).
>>>
>>> In this particular case it's really a hack to use _disposeFields to
>>> silence the disposer, since according to the doc _scroller is a proper
>>> qooxdoo object instance which you should use _disposeObject for. But
>>> there you go...
>>>
>>> Thomas
>>>
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
