John & Jim, >From testing out your heroku installed version, here are my thoughts:
- It took me awhile to find the plus sign. Maybe between the header row and the attachments themselves there could be a "+ Add" that, when clicked, could expand the form in place kinda like you do now. Otherwise, I think it could slam to the left against the "Attachments (count)" - I think the (-) image is too prominent, being the first thing you see when scanning the line. Removing attachments is probably the least common action, so I think it should be somewhere with lower importance. Maybe the order could be: Thumbnail, Filename, Magnifier icon for view, minus icon for delete, then description below - Given that the whole image row is draggable, it'd be nice if I could drag it into the body text and drop it to have the radius tags put in that cursor spot - When adding a new file... - - The (-) for cancel is kinda floating in space. - - I don't think the average user would expect to hit "Save and Continue Editing" just to upload the file. - - It might be most reasonable to have a fourth line with an "Upload" button and a "cancel" text link - - I wonder if the file selection/upload wouldn't best be handled in a modal dialog Overall I really like the functionality, so apologies if this feedback sounds overly critical! I look forward to your work being rolled into the official page_attachements repo. - Jeff --- Jeff Casimir Jumpstart Lab by Casimir Creative, LLC http://jumpstartlab.com @jumpstartlab on twitter On Tue, Jun 29, 2010 at 12:56 AM, john muhl <johnm...@gmail.com> wrote: > Jim (saturnflyer) and i have been working (most of the important work > is Jim's) on a branch of page_attachments that adds some new interface > features to the page_attachments extension and i'd like to have some > feedback on the work so far (note the "grid" view still needs some > work but you can get the basic idea). you can check out the code at > <http://github.com/johnmuhl/radiant-page-attachments-extension> and in > case you don't have the time/inclination to install it and test it > locally i've setup a demo at <http://pure-cloud-78.heroku.com/> (use > admin/radiant to login; feel free to upload some files and mess > around). > > are there any objections or concerns with having these changes merged > into the official p_a repo? > > any feedback is appreciated. >
