pablobm left a comment (openstreetmap/openstreetmap-website#6794)

I had a look. If I'm reading the code correctly, the "new note" UI doesn't 
"know" where the note will be placed. On submit, it reads it from the marker 
and uses that:

https://github.com/openstreetmap/openstreetmap-website/blob/94888241aef51eb3cd79300b5e7bd7954de8bedb/app/assets/javascripts/index/new_note.js#L140-L149

This makes me think that a refactor to use Rails conventions won't necessarily 
change this specific situation. For the Rails web backend to check each new 
location, the form would need to be reloaded every time the marker moves, which 
is probably not desirable. Therefore, binding to the repositioning event and 
checking the API every time seems like the best option in either case.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6794#issuecomment-4506935042
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/issues/6794/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to