@tomhughes commented on this pull request.
> + signup_param = ref_params["allow_signup"].first
+ @allow_signup = !signup_param || signup_param != "false"
As `nil != "false"` is true I think you can just write this as:
```suggestion
@allow_signup = ref_params["allow_signup"].first != "false"
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7138#pullrequestreview-4444905367
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7138/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
