@simonpoole commented on this pull request.
> + signup_param = ref_params["allow_signup"].first
+ @allow_signup = !signup_param || signup_param != "false"
Fixed that, thanks.
And I've addressed the lint issue too. Will squash later. My main issue is that
I get an unmanageable number of errors when running the tests locally (and
that's the reason for the noise here), must be doing something wrong. Though
tons of stuff is failing here too.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7138#discussion_r3369238245
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7138/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
