@tomhughes commented on this pull request.
> @@ -75,10 +75,12 @@
</div>
</div>
<% else %>
- <div class="d-inline-flex btn-group login-menu">
- <%= link_to t(".log_in"), login_path(:referer => request.fullpath),
:class => "geolink btn btn-outline-secondary" %>
- <%= link_to t(".sign_up"), new_user_path, :class => "btn
btn-outline-secondary" %>
- </div>
+ <% if allow_signup %>
+ <div class="d-inline-flex btn-group login-menu">
+ <%= link_to t(".log_in"), login_path(:referer => request.fullpath),
:class => "geolink btn btn-outline-secondary" %>
> Is it your intention to hide the login button for all pages unless your new
> parameter is present?
I hope that isn't the intention - as far as I know the intention is for the
default to be the same as now but to provide a way to suppress it.
The naming is based on an equivalent parameter in the GitHub OAuth flow I
believe.
The goal is basically to avoid some issues with the Android app verification
process where having the signup link can mean the OSM site itself becomes part
of the verification or something.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7138#discussion_r3369618903
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7138/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
