@simonpoole commented on this pull request.
> @@ -75,10 +75,12 @@
</div>
</div>
<% else %>
- <div class="d-inline-flex btn-group login-menu">
- <%= link_to t(".log_in"), login_path(:referer => request.fullpath),
:class => "geolink btn btn-outline-secondary" %>
- <%= link_to t(".sign_up"), new_user_path, :class => "btn
btn-outline-secondary" %>
- </div>
+ <% if allow_signup %>
+ <div class="d-inline-flex btn-group login-menu">
+ <%= link_to t(".log_in"), login_path(:referer => request.fullpath),
:class => "geolink btn btn-outline-secondary" %>
@hlfan as mentioned above I only started the PR at this point to see what the
problems with the tests were that were failing locally (which was due to the
firefox dependency missing in the installation instructions see above). So no
everything should stay the same and it does so locally as that specific issue
has been fixed, there's two tests still failing which I looking at right now.
Ans yes it sucks that we even have to faff around with this, but there is no
arguing with google.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7138#discussion_r3369628411
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/7138/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
