Comment #33 on issue 489 by [email protected]: [ ] DON'T SHIP IT button
http://code.google.com/p/reviewboard/issues/detail?id=489

All the discussion above highlights a very nice enhancement, but I just thought to put down what I've been doing as a possible work around.

In order for code being valid for "shipping" it needs x no of "Ship It!"'s and no "open issues".

For example:
Dev A comes along and says "Ship It!", but then Dev B finds a problem and opens and issue. Because there are still issues open, the "Ship It!" is not valid and simply comments on the fact that Dev A found it ok to go.

This prevents code from being shipped despite someone having clicked "Ship It!".

A delete 'Ship It!' would still be nice for accidental clicks, and it would be cool to see the no of open issues on the dashboard.


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to