Comment #34 on issue 489 by [email protected]: [ ] DON'T SHIP IT button
http://code.google.com/p/reviewboard/issues/detail?id=489
Here's what I've been thinking:
A 3-way toggle between: "Ship it!", "Undecided", and "Hold it!" per
reviewer. (See attachment)
A reviewer's default state is "Undecided".
Maybe each review will also have a counter to indicate the number of "ship
it"'s and "hold it"'s the review request has received, and possibly list
the reviewers who have given it the ship it's and hold it's.
Whoever is pushing the code will also be warned before pushing if the
review request has any "hold it"'s, but this will not restrict them from
pushing.
This will allow people to undo any Ship it/Hold it actions done
intentionally or accidentally, or change their stance after a request has
been updated or after further review.
Attachments:
3waytoggle.png 4.5 KB
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
