We're making this slightly less confusing in the upcoming UI rewrite. The
"Set Submitted" link is going away, and instead there will be a "Close"
drop-down with "Discard" and "Submitted." It doesn't entirely eliminate the
problem, but it's I think an improvement.

I'm slowly working on a manual that should make this more clear if people
get confused.


Christian Hammond - chip...@chipx86.com
VMware, Inc.

On Fri, Dec 19, 2008 at 12:53 PM, morisgi <gilles.mo...@free.fr> wrote:

> On Dec 19, 3:56 pm, "Russell Bryant" <russell.bry...@gmail.com> wrote:
> >
> > I believe that most people use the review with a tag of "Ship it" as the
> > approval.  The "set submitted" functionality is intended to be used by
> the
> > committer of the change after it has been approved and committed, to mark
> > the review as completed/closed.
> >
> > --
> > Russell
> OK, I understand.
> So may be we should name it approved, committed or completed instead
> of Submitted then.
> >

You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
For more options, visit this group at 

Reply via email to