That's pretty much why we use Submit. This began as a small tool for use inside our team at VMware, where we used Perforce.
I agree that Commit is more standard. We can make this change in the public UI, but the API and database will have to remain Submitted. I'm not loving the inconsistency there, but there's not a great solution to that. Christian -- Christian Hammond - [email protected] VMware, Inc. On Tue, Dec 30, 2008 at 7:54 AM, Jeff Andros <[email protected]> wrote: > Depends on which VCS you're using. CVS and SVN (and probably others) use > the term "commit", but P4 at least uses the term "submit". I'm sure there > are others as well. > Jeff > O|||||||O > > Help me and the Leukemia and Lymphoma society fight blood cancers: > http://pages.teamintraining.org/dm/tucson08/jandros > > > 2008/12/30 Arthur Kalmenson <[email protected]> > > >> > My two cents: "Submitted" should be "Committed". To reflect the repo- >> > lingo... >> >> I agree... >> >> -- >> Arthur Kalmenson >> >> >> >> On Tue, Dec 30, 2008 at 5:53 AM, Ibmurai <[email protected]> wrote: >> > >> > My two cents: "Submitted" should be "Committed". To reflect the repo- >> > lingo... >> > >> > On 23 Dec., 10:20, "Christian Hammond" <[email protected]> wrote: >> >> We're making this slightly less confusing in the upcoming UI rewrite. >> The >> >> "Set Submitted" link is going away, and instead there will be a "Close" >> >> drop-down with "Discard" and "Submitted." It doesn't entirely eliminate >> the >> >> problem, but it's I think an improvement. >> >> >> >> I'm slowly working on a manual that should make this more clear if >> people >> >> get confused. >> >> >> >> Christian >> >> >> >> -- >> >> Christian Hammond - [email protected] >> >> VMware, Inc. >> >> >> >> >> >> >> >> On Fri, Dec 19, 2008 at 12:53 PM, morisgi <[email protected]> >> wrote: >> >> >> >> > On Dec 19, 3:56 pm, "Russell Bryant" <[email protected]> >> wrote: >> >> >> >> > > I believe that most people use the review with a tag of "Ship it" >> as the >> >> > > approval. The "set submitted" functionality is intended to be used >> by >> >> > the >> >> > > committer of the change after it has been approved and committed, >> to mark >> >> > > the review as completed/closed. >> >> >> >> > > -- >> >> > > Russell >> >> >> >> > OK, I understand. >> >> > So may be we should name it approved, committed or completed instead >> >> > of Submitted then.- Skjul tekst i anførselstegn - >> >> >> >> - Vis tekst i anførselstegn - >> > > >> > >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---
