On Tue, Jan 6, 2009 at 10:15 AM, SamClark <[email protected]> wrote:
>
> So... a few things. I haven't mentioned in this post that I'm on a
> windows machine. Maybe I should
>
I was doing all this stuff on a Windows machine too, so don't worry.
It should work in the end :)

> Running at the command line:
>
> svn cat 
> http://localhost/svnrepo/Firmware/Projects/Hello/branches/Hello_b_1_0_0_TestReview/source/hello.c
> -r 11 >old
>
> svn cat 
> http://localhost/svnrepo/Firmware/Projects/Hello/branches/Hello_b_1_0_0_TestReview/source/hello.c
> -r 12 >new
>
> diff -u old new >patch
>
> Yields this output for the file 'patch':
> -------------------------------------------------------
> --- old 2009-01-06 10:16:19.834724200 -0700
> +++ new 2009-01-06 10:16:08.943681000 -0700
> @@ -5,6 +5,7 @@
>  int main(void)
>  {
>        printf("There are %d months in a year", TWELVE);
> +    printf("Another revision");
>        return;
>  }
>
>
> -------------------------------------------------------
> I can't seem to produce an output file using:
>
> patch -u --input=patch --output=patched old
>
What does patch say? The patch file looks fine to me. I actually can't
see any difference between this and the one produced by svn diff.

> Which leads me to believe patch doesn't understand my patch. I tried
> to post a new review by hand using the above file 'patch'. Review
> board told me it couldn't parse the first line (Unable to parse diff
> revision header '2009-01-06 10:16:19.834724200 -0700').
>
That's expected, because the svn patch parser expects svn patches
(which contain revision numbers after file paths). You can fix it
manually if you want to, by mimicking what svn diff outputs for the
files (i.e. revision 11/12 etc)


Regards
-- 
Muhammad Haggag

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to