To add support for diffing against any version, you need to implement the ClearCaseTool's get_file function to take into account the specified revision. If you can return the right revision from that, you should be good.
That might have to do with why you're seeing the "old" version in both. You *should* have a patched version in the right-hand side, but there's certainly going to be issues with get_file() not supporting revisions. So I'd look into that first. Also, make sure the code is parsing useful revisions out of the diffs (and the diffs should contain useful revisions to parse). I don't know enough about the clearcase support to know whether this works today. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Tue, Apr 7, 2009 at 6:43 AM, Lars Olsson <lars.olsso...@gmail.com> wrote: > hi, > > my current status: > > post-review: > - some smaller patches to post-review tool regading filename handling so it > finds the files. > - configuration of view and server name > > - removed "import cleartool" from clearcase.py > - In Reviewboard UI, added a new tool for ClearCase using classes in > clearcase.py > - Added a new repository with clearcase tool. > > Result: > - A diff. is created and uploaded to the server by the post-review tool. > - a new pending review request is created. > > > Problems: > - When selecting "View Diffs", I see the "old" version of the file in both > columns. "Download Diff"gives the correct diff (uploaded by the post-review > tool). > Any one knows why? Am I missing something? I have not installed the > highlighting tool but that should not affect this, right? > > - If I would like to diff the current version against any given version ( > not only the previous version ) how do I do that? > > best regards, > Lars > > > > 2009/4/3 Dan Savilonis <d...@n-cube.org> > > >> I haven't tried the Clearcase support myself, but there is definitely >> a ClearCaseClient class in post-review. Are you sure you have an up-to- >> date copy of rbtools? >> >> You can see the latest post-review here: >> >> http://code.google.com/p/reviewboard/source/browse/trunk/rbtools/scripts/post-review >> >> Dan >> >> On Apr 2, 8:41 am, Bartlomiej Celary <bartlomiej.cel...@gmail.com> >> wrote: >> > Hi, >> > I am looking for that info as well. >> > >> > From what I can see (from today's svn checkout ofhttp:// >> reviewboard.googlecode.com/svn/trunk/reviewboard) there is a >> > ClearCaseTool class for it. I tried adding a repo tool like so: >> > >> > Tool: Clearcase >> > Class name: reviewboard.scmtools.clearcase.ClearCaseTool >> > >> > But I cannot see any changes in post-review tool. There is no mention >> > about clearcase or cleartool. How do I post diffs for review with >> > clearcase? >> > >> > Best regards, >> > Bartek Celary >> > >> > 2009/3/26 lasseo <lars.olsso...@gmail.com>: >> > >> > >> > >> > > Hi all, >> > >> > > As from Review Board 1.0 alpha 2, there is an announced support for >> > > Clearcase. >> > > Yesterday, I downloaded the alpha 4 version with the hope of getting >> > > it up and running against our clearcase environment. >> > >> > > Unfortunately, I can not find any documentation on how to configure it >> > > for Clearcase. >> > > Are there any examples present on the website/net? >> > >> > > Can someone please provide hints on how to configure it? >> > >> > > My issues so far: >> > > - At the moment I can not select Clearcase as tool when adding a >> new >> > > repository >> > > - What is the syntax when adding a clearcase repository >> > > - How and where do I specify my Clearcase view? >> > >> > > All hints are appreciated. >> > >> > > Best Regards, >> > > Lars >> > >> > >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to firstname.lastname@example.org To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~----------~----~----~----~------~----~------~--~---