On Thu, Apr 30, 2009 at 3:29 AM, Alexey Morozov <morozov...@ngs.ru> wrote:

> > (On a side note, you have the wrong base diff path set in the patch you
> > uploaded, so I can't see it.)
> Heh, thank you, I've just fixed it. "Base directory" was wrong, I had to
> manually edit the diff generated by git to fulfil reviewboard SVN diff
> parser
> expectations and made a mistake.
> Maybe it's worth to add a tip on the page about how a particular VCS
> patches
> should be prepared. Yes, I do remember about your `post-review` advise, but
> I
> didn't have neither svn nor git-svn nor external network connection on the
> (virtual) host where I made the changes :)

I'd like to make this more clear after 1.0, and we're going to have it
verify the diff when submitting so that people will catch this early. The
goal is to have this for 1.5.


Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com

You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
For more options, visit this group at 

Reply via email to