Hi, Scott,
I want to know, If we set all those code-review process after code
commition, We do post-commit review, Then how to realize that?
I had use post-review to generate a post-commit review request for specific
files, But failed.
My command is:
post-review --debug --revision-range=1.1:1.2 --summary=Null
--target-people=john -p post-review.c
But the out put is:
----------------------------------------
>>> cvs diff -uN -r 1.1 -r1.2
>>>....
>>> Your review request still exists, but the diff is not attached
-----------------------------------------------
I want to know, Why the post-review has droped my file name parameter?
And if I have more then one file to make post-commit review, Then how to
specify the revision-range to each of them? Need suggestion!
Best Regards!
在2009-12-22，"Scott Quesnelle" <[email protected]> 写道：
We are doing reviews prior to the changes being commited to CVS.
To enforce this process, you can modify the CVS pre-commit script. This script
can then check change for review approval.
We currently require the bugid to be in the cvs commit log, as such we query
the bug tracking system and check if the bug is in the review state and has an
enclosure containing the review summary. The enclosure gets added to the bug
report when the user moves the review request to 'close (submitted)'.
CVS doesn't deal well with rolling back changes, and we only want 'good
reviewed code' to enter our repository, so do all our reviews prior to commit.
Scott
2009/12/20 qhlonline <[email protected]>
Hi, all.
Our team is now requiring that the code review will be an indispensable
step in development. So we want to integrate the Repository with the
ReviewBoard server. Then the development process will be:
1、Somebody have developed or have changed some source code of a product.
2、He use "cvs add", or then " cvs commit" command to commit his code.
3、CVS can then generate a Reviewrequest for this code change to RB. Reviewboard
will notice the reviewers of the default review groups to make the code
review.(The default review group will be where the commitor is in).
4、All reviewers can review those code through web UI, And the code commitor
will fix all found bugs and recommit.
5、When all reviewers has admitted that the code is OK， Then the code will
automatically commit to the CVS repository.
6、optionally，A notice of code commit success will given to all participants.
That is, When the code editor want to commit his code, His code should be
firstly reviewed. No truely commit to repository if any reviewer do not accept
his code. This process should be forced instead of optional. Then how to
realize those function? especially how to integrate CVS with ReviewBoard
server? Need suggestions or documents related.
Best Regards!
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
