Sorry for the delay. Busy week, and I'm fighting a cold, so I'm not paying as much attention to e-mail as I'd prefer.
Do you happen to have a file named 'master' in that directory? Is there a branch named 'master'? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Jan 28, 2010 at 9:50 AM, Kunjal <kunjal.par...@gmail.com> wrote: > Any update on this issue? > > On Jan 26, 1:14 pm, Kunjal <kunjal.par...@gmail.com> wrote: > > git version 1.6.0.4 > > > > On Jan 26, 11:39 am, Christian Hammond <chip...@chipx86.com> wrote: > > > > > > > > > Git, not Review Board. > > > > > Christian > > > > > -- > > > Christian Hammond - chip...@chipx86.com > > > Review Board -http://www.reviewboard.org > > > VMware, Inc. -http://www.vmware.com > > > > > On Tue, Jan 26, 2010 at 9:55 AM, Kunjal <kunjal.par...@gmail.com> > wrote: > > > > I am using 1.0.5.1 > > > > > > On Jan 25, 3:12 pm, Christian Hammond <chip...@chipx86.com> wrote: > > > > > What version of Git are you using? > > > > > > > Christian > > > > > > > -- > > > > > Christian Hammond - chip...@chipx86.com > > > > > Review Board -http://www.reviewboard.org > > > > > VMware, Inc. -http://www.vmware.com > > > > > > > On Mon, Jan 25, 2010 at 10:13 AM, Kunjal <kunjal.par...@gmail.com> > > > > wrote: > > > > > > I just try to post the review. > > > > > > > > my git branch -a shows: > > > > > > git branch -a > > > > > > donut > > > > > > * kunjal > > > > > > > > postreview.py --parent=origin/donut > > > > > > Failed to execute command: ['git', 'diff', '--no-color', '--full- > > > > > > index', 'master'] > > > > > > fatal: ambiguous argument 'master': unknown revision or path not > in > > > > > > the working tree. > > > > > > Use '--' to separate paths from revisions > > > > > > > > On Jan 25, 9:48 am, Kunjal <kunjal.par...@gmail.com> wrote: > > > > > > > Thanks a lot. > > > > > > > > > One question... > > > > > > > > > In the Add repository dialog, I have provided repository path > as > > > > > > > git://mobcom-git.sj.broadcom.com/git_repos. Is that correct? > > > > > > > > > We have our all repositories stored at > /projects/xxx/xxx/git_repos. > > > > > > > > > Also, on the local workspace, user must do --> git config > > > > > > > reviewboard.urlhttp://reviewboard.example.com > > > > > > > This could be part of .cshrc file so every user does not have > to do > > > > it > > > > > > > all the time. > > > > > > > > > After I do 2 above steps, am I ready to post-review or some > more > > > > > > > config is needed? I am using nigthlies as of Jan25. > > > > > > > > > Kunjal > > > > > > > > > On Jan 24, 5:20 pm, Christian Hammond <chip...@chipx86.com> > wrote: > > > > > > > > > > Hi, > > > > > > > > > > Git support in Review Board 1.1 (soon to be renamed 1.5) is > much > > > > better > > > > > > than > > > > > > > > in 1.0.x. Git has no concept of checking out individual files > from > > > > a > > > > > > remote > > > > > > > > repository, so in 1.0.x, you need to make sure that you have > a > > > > > > repository on > > > > > > > > a filesystem accessible from the Review Board server and it > needs > > > > to be > > > > > > > > constantly up-to-date with a master repository. > > > > > > > > > > In 1.5, if you have a web-based repository viewer set up for > your > > > > Git > > > > > > > > repository (such as cgit, gitweb, GitHub, etc.) then you can > > > > specify a > > > > > > path > > > > > > > > to a "raw file" URL that provides a raw checkout of the file > based > > > > on > > > > > > > > revision and filename. Review Board will use this to grab the > files > > > > > > instead > > > > > > > > of needing a local checkout. It's much easier to maintain, > and > > > > we're > > > > > > going > > > > > > > > to recommend this route going forward. > > > > > > > > > > As for post-review, it's had Git support for a long time. I > imagine > > > > > > your > > > > > > > > copy is just out of date. The class should be named > "GitClient." > > > > The > > > > > > > > nightles are preferred for Git, though, as there's a number > of > > > > > > important > > > > > > > > fixes for determining parent branches. I plan to cut a > release > > > > soon. > > > > > > > > > > To run post-review with Git, you can just type `post-review` > and it > > > > > > will > > > > > > > > generate a diff from the origin to HEAD. If you specify > > > > > > > > --parent=<branchname> then it will generate from branchname > to > > > > HEAD. > > > > > > > > > > Christian > > > > > > > > > > -- > > > > > > > > Christian Hammond - chip...@chipx86.com > > > > > > > > Review Board -http://www.reviewboard.org > > > > > > > > VMware, Inc. -http://www.vmware.com > > > > > > > > > > On Sun, Jan 24, 2010 at 5:11 PM, Kunjal < > kunjal.par...@gmail.com> > > > > > > wrote: > > > > > > > > > Last question... > > > > > > > > > > > Does the GIT support available in RB 1.0.5 or I have to > move to > > > > RB > > > > > > 1.1 > > > > > > > > > Alpha 2? > > > > > > > > > Sorry for all these questions. > > > > > > > > > > > On Jan 24, 12:04 pm, Kunjal <kunjal.par...@gmail.com> > wrote: > > > > > > > > > > One more thing... > > > > > > > > > > The post-review script we have has the class called > > > > PerforceClient > > > > > > > > > > which gets the repository info. and creates diff. > > > > > > > > > > I do not see any class for GITClient. > > > > > > > > > > Do I need to create such class on my own? > > > > > > > > > > > > Thanks > > > > > > > > > > Kunjal > > > > > > > > > > > > On Jan 23, 11:10 am, Kunjal <kunjal.par...@gmail.com> > wrote: > > > > > > > > > > > > > Hello Chris, > > > > > > > > > > > > > We do have RB-Perforce integration working perfect! > > > > > > > > > > > We want RB-GIT integration as well. > > > > > > > > > > > > > Here are the steps I can think of. Can you evaluate it? > > > > > > > > > > > > > 1. Add new repository for GIT in RB. > > > > > > > > > > > 2. Install RB tools in Linux machines. We do have our > own > > > > version > > > > > > of > > > > > > > > > > > post-review. can we just replace it? > > > > > > > > > > > 3. what are the commands to be used to post review? For > > > > perforce, > > > > > > we > > > > > > > > > > > are using post-review.exe 234545 > > > > > > > > > > > For GIT, I have to give latest commit number? > post-review > > > > > > 0er545455 ? > > > > > > > > > > > 4. Any other things I need to take care. > > > > > > > > > > > > > Thanks for your help. > > > > > > > > > > > > > Kunjal- Hide quoted text - > > > > > > > > > > > > - Show quoted text - > > > > > > > > > > > -- > > > > > > > > > Want to help the Review Board project? Donate today at > > > > > > > > >http://www.reviewboard.org/donate/ > > > > > > > > > Happy user? Let us know athttp:// > www.reviewboard.org/users/ > > > > > > > > > -~----------~----~----~----~------~----~------~--~--- > > > > > > > > > To unsubscribe from this group, send email to > > > > > > > > > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > <reviewboard%2bunsubscr...@googlegroups.com> > > > > <reviewboard%2bunsubscr...@googlegroups.com> > > > > > > <reviewboard%2bunsubscr...@googlegroups.com> > > > > > > > > > For more options, visit this group at > > > > > > > > > > http://groups.google.com/group/reviewboard?hl=en-Hidequotedtext > > > > - > > > > > > > > > > - Show quoted text -- Hide quoted text - > > > > > > > > > - Show quoted text - > > > > > > > > -- > > > > > > Want to help the Review Board project? Donate today at > > > > > >http://www.reviewboard.org/donate/ > > > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > > > -~----------~----~----~----~------~----~------~--~--- > > > > > > To unsubscribe from this group, send email to > > > > > > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > <reviewboard%2bunsubscr...@googlegroups.com> > > > > <reviewboard%2bunsubscr...@googlegroups.com> > > > > > > For more options, visit this group at > > > > > >http://groups.google.com/group/reviewboard?hl=en-Hidequoted text > - > > > > > > > - Show quoted text - > > > > > > -- > > > > Want to help the Review Board project? Donate today at > > > >http://www.reviewboard.org/donate/ > > > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > > > -~----------~----~----~----~------~----~------~--~--- > > > > To unsubscribe from this group, send email to > > > > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > <reviewboard%2bunsubscr...@googlegroups.com> > > > > For more options, visit this group at > > > >http://groups.google.com/group/reviewboard?hl=en-Hide quoted text - > > > > > - Show quoted text -- Hide quoted text - > > > > - Show quoted text - > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~----------~----~----~----~------~----~------~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com<reviewboard%2bunsubscr...@googlegroups.com> > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
