I sort of figured that the aging colors would be hardcoded.  Thanks
for the suggestion and the willingness to accept a patch, but I don't
think it matters quite that much.  I might revisit this if I find
myself with nothing else to do at work sometime in the next six months
or so.

On Aug 25, 9:28 pm, Christian Hammond <chip...@chipx86.com> wrote:
> That was a terrible suggestion that clearly won't work right. I shouldn't
> propose code when heavily distracted.
>
> So what you'd need is some function that can be provided to do the
> equivalent of the "if delta.days ..." logic. So instead, perhaps allow for
> setting a "get_djblets_ageid_func" function in settings, and if it exists,
> call it, passing in the delta. If not, use the existing logic. Then you guys
> can do any sort of calculation you want.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Thu, Aug 25, 2011 at 6:20 PM, Christian Hammond <chip...@chipx86.com>wrote:
>
>
>
> > Hi,
>
> > This is all hard-coded in djblets/util/templatetags/djblets_utils.py in the
> > "ageid" function.
>
> > If you really want this, I'd be willing to accept a patch that looked up
> > those date ranges in settings and used them if found. Something like:
>
> >     from django.conf import settings
>
> >     DEFAULT_DATE_RANGES = {
> >         0: 'age1',
> >         1: 'age2',
> >         ...
> >     }
>
> >     ...
>
> >     def age_id(...):
> >         ...
> >         age_ranges = settings.get('AGE_RANGES', DEFAULT_DATE_RANGES)
> >         return age_ranges.get(delta.days, "age5")
>
> > Then you could customize this in your settings_local.py file for your
> > install.
>
> > Christian
>
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.reviewboard.org
> > VMware, Inc. -http://www.vmware.com
>
> > On Thu, Aug 25, 2011 at 7:14 AM, virtualAdmin <mrcul...@gmail.com> wrote:
>
> >> Hi all,
>
> >> From what I can tell, our organization's process is a little more
> >> relaxed than most RB users.  We're a very small team, so we submit
> >> code reviews (via the Web interface) after committing to SVN, by
> >> taking a manual diff from the command line and uploading it.  We also
> >> take our good old time getting around to commenting on the reviews,
> >> sometimes a very long time.  This isn't ideal, but it's the way we do
> >> it and it works for us.
>
> >> So my question is, is there any reasonably simple way of changing the
> >> amount of time it takes for the review to change colors on the
> >> dashboard?  For us, one day of no activity doesn't put a review in the
> >> yellow zone, it's more like a week.  And likewise requests shouldn't
> >> turn red until maybe a month has elapsed.
>
> >> Thanks!
>
> >> --
> >> Want to help the Review Board project? Donate today at
> >>http://www.reviewboard.org/donate/
> >> Happy user? Let us know athttp://www.reviewboard.org/users/
> >> -~----------~----~----~----~------~----~------~--~---
> >> To unsubscribe from this group, send email to
> >> reviewboard+unsubscr...@googlegroups.com
> >> For more options, visit this group at
> >>http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Reply via email to